On 05/07/2013 02:01 AM, Marc Dietrich wrote:
> Hi,
> 
> Am Montag, 6. Mai 2013, 13:08:31 schrieb Stephen Warren:
>> On 05/04/2013 06:01 AM, Heiko Schocher wrote:
>>> From: Simon Glass <s...@chromium.org>
>>>
>>> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the
>>> Tegra i2c driver to support this.
>>>
>>>  include/configs/beaver.h    |  5 ++-
>>>  include/configs/cardhu.h    |  3 +-
>>>  include/configs/dalmore.h   |  3 +-
>>>  include/configs/seaboard.h  |  5 ++-
>>>  include/configs/trimslice.h |  5 ++-
>>>  include/configs/whistler.h  |  5 ++-
>>
>> There are a lot more Tegra boards than just those. Shouldn't they all be
>> updated? You also didn't Cc the Tegra maintainer - I have done on this mail.
> 
> not all boards use I2C up to now, to the patch seems to change only the 
> boards 
> which do. So this is ok for now. The question is if CONFIG_SYS_I2C could be 
> moved to tegra_common or so because the device-tree disables I2C be default.

Yes, we should do that for all the devices that are now
instantiated/configured using device tree. But, we can do that as a
separate patch series after this.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to