Hi Alison, On Wednesday, May 22, 2013 5:17:41 AM, Wang Huan-B18965 wrote: > Hi, Benoit, > > > -----Original Message----- > > From: Benoît Thébaudeau [mailto:[email protected]] > > Sent: Wednesday, May 22, 2013 1:29 AM > > To: Wang Huan-B18965 > > Cc: [email protected]; [email protected]; TsiChung Liew; Jin Zhengxiong- > > R64188; Estevam Fabio-R49496 > > Subject: Re: [U-Boot] [PATCH v3 6/6] arm: mvf600: Add basic support for > > Vybrid MVF600TWR board > > > > Hi Alison, > > > > On Tuesday, May 21, 2013 11:03:01 AM, Alison Wang wrote: > > > MVF600TWR is a board based on Vybrid MVF600 SoC. > > > > > > This patch adds basic support for Vybrid MVF600TWR board. > > > > > > Signed-off-by: Alison Wang <[email protected]> > > > Signed-off-by: Jason Jin <[email protected]> > > > Signed-off-by: TsiChung Liew <[email protected]> > > > > [...] > > > > > diff --git a/include/configs/mvf600twr.h b/include/configs/mvf600twr.h > > > new file mode 100644 index 0000000..1cfb9f6 > > > --- /dev/null > > > +++ b/include/configs/mvf600twr.h > > > @@ -0,0 +1,140 @@ > > > +/* > > > + * Copyright 2013 Freescale Semiconductor, Inc. > > > + * > > > + * Configuration settings for the Freescale Vybrid mvf600twr board. > > > + * > > > + * This program is free software; you can redistribute it and/or > > > + * modify it under the terms of the GNU General Public License as > > > + * published by the Free Software Foundation; either version 2 of > > > + * the License, or (at your option) any later version. > > > + * > > > + * This program is distributed in the hope that it will be useful, > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > + * GNU General Public License for more details. > > > + * > > > + * You should have received a copy of the GNU General Public License > > > + * along with this program; if not, write to the Free Software > > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > > > + * MA 02111-1307 USA > > > + */ > > > + > > > +#ifndef __CONFIG_H > > > +#define __CONFIG_H > > > + > > > +#include <asm/arch/imx-regs.h> > > > +#include <config_cmd_default.h> > > > + > > > +#define CONFIG_MVF600 > > > + > > > > [...] > > > > > +#define CONFIG_CMD_PING > > > +#define CONFIG_CMD_DHCP > > > +#define CONFIG_CMD_MII > > > +#define CONFIG_CMD_NET > > > +#define CONFIG_FEC_MXC > > > +#define CONFIG_MII > > > +#define IMX_FEC_BASE ENET_BASE_ADDR > > > +#define CONFIG_FEC_XCV_TYPE RMII > > > +#define CONFIG_ETHPRIME "FEC" > > > > You don't need to define this one with only 1 Ethernet interface defined. > > But isn't the MVF600 a dual-Ethernet SoC? > [Alison Wang] Yes, MVF600 is a dual-Ethernet SoC. I will change it to "FEC0". > Thanks.
CONFIG_ETHPRIME should just be removed if you are not going to enable the 2nd FEC in U-Boot. But if you plan to enable the 2nd FEC, which will have to be done now or later for a dual-Ethernet SoC, then you have to: - remove CONFIG_FEC_MXC_PHYADDR and IMX_FEC_BASE, - define CONFIG_ETHPRIME to "FEC0", - call fecmxc_initialize_multi() once for each FEC instead of calling fecmxc_initialize() from cpu_eth_init() in generic.c (you can define ENET1_BASE_ADDR and ENET2_BASE_ADDR instead of ENET_BASE_ADDR in imx-regs.h, and CONFIG_FEC1_MXC_PHYADDR and CONFIG_FEC2_MXC_PHYADDR instead of CONFIG_FEC_MXC_PHYADDR in mvf600twr.h, then pass them to fecmxc_initialize_multi() from cpu_eth_init(), with 0 and 1 as the IDs), - add support for the 2nd FEC in imx_get_mac_from_fuse(), - update doc/README.mvf600 to say which fuses are used for the MAC address of the 2nd FEC. [...] Best regards, Benoît _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
