Re: [U-Boot] [PATCH] s3c64xx: move reset_cpu to soc and support the soft reset at s3c6410

[Jean-Christophe PLAGNIOL-VILLARD]

On 17:51 Fri 03 Apr     , Minkyu Kang wrote:
> This patch support the soft reset at s3c6410
> 
> Signed-off-by: Minkyu Kang <mk7.k...@samsung.com>
> ---
>  cpu/arm1176/cpu.c                |   16 ----------------
>  cpu/arm1176/s3c64xx/interrupts.c |   15 +++++++++++++++
>  include/s3c6400.h                |    5 +++++
>  3 files changed, 20 insertions(+), 16 deletions(-)
> 
> diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c
> index 1e94f7d..fe41290 100644
> --- a/cpu/arm1176/cpu.c
> +++ b/cpu/arm1176/cpu.c
> @@ -107,22 +107,6 @@ int cleanup_before_linux (void)
>       return 0;
>  }
>  
> -
> -/* * reset the cpu by setting up the watchdog timer and let him time out */
> -void reset_cpu (ulong ignored)
> -{
> -     printf("reset... \n\n\n");
> -     SW_RST_REG = 0x6400;
> -     /* loop forever and wait for reset to happen */
> -     while (1) {
> -             if (serial_tstc()) {
> -                     serial_getc();
> -                     break;
> -             }
> -     }
> -     /*NOTREACHED*/
> -}
> -
>  int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>  {
>       disable_interrupts ();
> diff --git a/cpu/arm1176/s3c64xx/interrupts.c 
> b/cpu/arm1176/s3c64xx/interrupts.c
cpu.c will be better because interrupts.c will be rename timer.c with the new
timer cleanup work
> index 83f3806..e68f3ae 100644
> --- a/cpu/arm1176/s3c64xx/interrupts.c
> +++ b/cpu/arm1176/s3c64xx/interrupts.c
> @@ -175,3 +175,18 @@ void udelay(unsigned long usec)
>       while (get_ticks() < tmp)/* loop till event */
>                /*NOP*/;
>  }
> +
> +/* reset the cpu by setting up the watchdog timer and let him time out */
> +void reset_cpu(ulong ignored)
> +{
> +     printf("reset... \n\n\n");
> +     SW_RST_REG = SW_RST_CODE;
        writel?
> +     /* loop forever and wait for reset to happen */
> +     while (1) {
> +             if (serial_tstc()) {
> +                     serial_getc();
> +                     break;
> +             }
> +     }
> +     /*NOTREACHED*/
> +}
Best Regards,
J.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot