Dear ying.zh...@freescale.com, In message <1374571024-15729-2-git-send-email-ying.zh...@freescale.com> you wrote: > From: Ying Zhang <b40...@freescale.com> > > This patch introduces SPL to enable a loader stub that being loaded by > the code from the internal on-chip ROM. It loads the final uboot image > into DDR, then jump to it to begin execution. > > The SPL's size is sizeable, the maximum size must not exceed the size of L2 > SRAM. It initializes the DDR through SPD code, and copys final uboot image > to DDR. So there are two stage uboot images: > * spl_boot, 96KB size. The env variables are copied to L2 SRAM, so > that ddr spd code can get the interleaving mode setting in env. It > loads final uboot image from offset 96KB. > * final uboot image, size is variable depends on the functions > enabled. > > Signed-off-by: Ying Zhang <b40...@freescale.com>
So we have reached patch version 9 already, and you still submit code that is not checkpatch clean? Please explain how this is possible. This patch gives: WARNING: Avoid unnecessary line continuations #387: FILE: drivers/mmc/fsl_esdhc_spl.c:71: + err = mmc->block_dev.block_read(0, CONFIG_CFG_DATA_SECTOR, \ Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "It follows that any commander in chief who undertakes to carry out a plan which he considers defective is at fault; he must put forth his reasons, insist of the plan being changed, and finally tender his resignation rather than be the instrument of his army's downfall." - Napoleon, "Military Maxims and Thought" _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot