Dear Minkyu Kang, > -----Original Message----- > From: Piotr Wilczek [mailto:[email protected]] > Sent: Friday, August 30, 2013 8:01 AM > To: 'Minkyu Kang' > Cc: '[email protected]'; 'Kyungmin Park'; Lukasz Majewski > Subject: RE: [PATCH V4 1/3] power:battery: add battery support for > Trats2 board > > Dear Minkyu Kang, > > > -----Original Message----- > > From: Minkyu Kang [mailto:[email protected]] > > Sent: Friday, August 30, 2013 6:39 AM > > To: Piotr Wilczek > > Cc: [email protected]; Kyungmin Park; Lukasz Majewski > > Subject: Re: [PATCH V4 1/3] power:battery: add battery support for > > Trats2 board > > > > Dear Piotr Wilczek, > > > > On 29/08/13 17:49, Piotr Wilczek wrote: > > > Signed-off-by: Piotr Wilczek <[email protected]> > > > Signed-off-by: Kyungmin Park <[email protected]> > > > --- > > > drivers/power/battery/Makefile | 1 + > > > drivers/power/battery/bat_trats2.c | 65 > > ++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 66 insertions(+) > > > create mode 100644 drivers/power/battery/bat_trats2.c > > > > > > > bat_trats2.c is almost same with bat_trat.c I think, it can be reuse > > bat_trat.c Do you have special reason to add new file? > > If several boards would use that file, any change to it will affect all > these boards. Also why it should be named 'bat_trats' then? > > Other reason is that I don't want to block command line while charging > battery as in 'bat_trats'.
Is this reason good enough to add new file or should I post a new version of this patch? > > Anyway it's not that important. I will modify it the way you prefer. > > Best regards, > Piotr Wilczek > > > > > Thanks, > > Minkyu Kang. Best regards, Piotr Wilczek _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
