> -----原始邮件-----
> 发件人: "Wolfgang Denk" <[email protected]>
> 发送时间: 2013年9月11日 星期三
> 收件人: [email protected]
> 抄送: [email protected], [email protected], [email protected]
> 主题: Re: [PATCH v7 0/5] arm64 patch
>
> Dear [email protected],
>
> In message <[email protected]> you
> wrote:
> > From: David Feng <[email protected]>
> >
> > The porting has been merged with arm architecture.
> > Most architecture codes are placed in
> > arch/arm/cpu/armv8 directory. Generic board is also
> > supported after a few bugs are fixed.
> > u-boot could be running at EL1 or EL2.
> >
> > Changes for v6:
> > - Check the patches with checkpatch.pl and get rid of
> > almost all warnings. There are a few warnings still,
> > but I think it should be that.
>
> Please fix at least all of these:
>
> - WARNING: Avoid CamelCase: ...
The CamelCase such as nGnRnE are all taken from Armv8 ARM and
linux kernel define them in this way.
I think it is more readable. NGNRNE is a little strange.
> - CHECK: Blank lines aren't necessary before a close brace '}'
>
Sorry, I did not find any warnings about this.
Best regards,
David
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
> A memorandum is written not to inform the reader, but to protect the
> writer. -- Dean Acheson
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
