Dear Vivek Gautam, > Hi Marek, > > On Tue, Sep 17, 2013 at 8:32 AM, Marek Vasut <ma...@denx.de> wrote: > > Dear Vivek Gautam, > > > >> Macros defining bmRequestType field of USB device request, > >> given in table 9.2 USB 2.0 spec, are rather generic macros > >> which can be further used by other Host controller stacks. > >> So moving them to usb_defs header. > >> > >> Signed-off-by: Vivek Gautam <gautam.vi...@samsung.com> > >> Cc: Julius Werner <jwer...@chromium.org> > >> Cc: Simon Glass <s...@chromium.org> > >> Cc: Minkyu Kang <mk7.k...@samsung.com> > >> Cc: Dan Murphy <dmur...@ti.com> > >> Cc: Marek Vasut <ma...@denx.de> > > > > Why not just use include/usb.h ? > > The bit field definitions for usb-types usb-recipient, and directions > are itself defined in usb_defs.h; > so i thought of keeping their combination just below it, so that it > would not be difficult to reference. > > Please let me know if you want me to move them to include/usb.h
Ah, we already have usb_defs.h , then this is OK. The headers are mess and will eventually need cleanup too, not in this patchset of course. Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
