Hi Simon, I guess you meant decode_sromc and board_eth_init functions. Will add them in board.c and send next version.
Regards, Rajeshwari Shinde On Tue, Oct 8, 2013 at 11:07 PM, Simon Glass <s...@chromium.org> wrote: > Hi Rajeshwari, > > On Fri, Sep 27, 2013 at 6:10 AM, Rajeshwari S Shinde < > rajeshwar...@samsung.com> wrote: > >> Adding the base patch for Exynos based SMDK5420. >> This shall enable compilation and basic boot support for >> SMDK5420. >> >> Signed-off-by: Rajeshwari S Shinde <rajeshwar...@samsung.com> >> Signed-off-by: Akshay Saraswat <aksha...@samsung.com> >> --- >> Changes in V2: >> - None >> Changes in V3: >> - None >> Changes in V4: >> - Rebased on latest u-boot-samsung tree. >> board/samsung/common/board.c | 2 + >> board/samsung/smdk5420/Makefile | 34 +++++ >> board/samsung/smdk5420/smdk5420.c | 253 >> ++++++++++++++++++++++++++++++++++ >> board/samsung/smdk5420/smdk5420_spl.c | 52 +++++++ >> boards.cfg | 1 + >> tools/Makefile | 2 + >> 6 files changed, 344 insertions(+) >> create mode 100644 board/samsung/smdk5420/Makefile >> create mode 100644 board/samsung/smdk5420/smdk5420.c >> create mode 100644 board/samsung/smdk5420/smdk5420_spl.c >> >> diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c >> index 7193c90..ce85ddb 100644 >> --- a/board/samsung/common/board.c >> +++ b/board/samsung/common/board.c >> @@ -139,6 +139,7 @@ struct cros_ec_dev *board_get_cros_ec_dev(void) >> return local.cros_ec_dev; >> } >> >> +#ifdef CONFIG_CROS_EC >> static int board_init_cros_ec_devices(const void *blob) >> { >> local.cros_ec_err = cros_ec_init(blob, &local.cros_ec_dev); >> @@ -147,6 +148,7 @@ static int board_init_cros_ec_devices(const void *blob) >> >> return 0; >> } >> +#endif >> >> #if defined(CONFIG_POWER) >> #ifdef CONFIG_POWER_MAX77686 >> diff --git a/board/samsung/smdk5420/Makefile >> b/board/samsung/smdk5420/Makefile >> new file mode 100644 >> index 0000000..be538ec >> --- /dev/null >> +++ b/board/samsung/smdk5420/Makefile >> @@ -0,0 +1,34 @@ >> +# >> +# Copyright (C) 2013 Samsung Electronics >> +# >> +# SPDX-License-Identifier: GPL-2.0+ >> +# >> + >> +include $(TOPDIR)/config.mk >> + >> +LIB = $(obj)lib$(BOARD).o >> + >> +COBJS += smdk5420_spl.o >> + >> +ifndef CONFIG_SPL_BUILD >> +COBJS += smdk5420.o >> +endif >> + >> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) >> +OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS)) >> + >> +ALL := $(obj).depend $(LIB) >> + >> +all: $(ALL) >> + >> +$(LIB): $(OBJS) >> + $(call cmd_link_o_target, $(OBJS)) >> + >> +######################################################################### >> + >> +# defines $(obj).depend target >> +include $(SRCTREE)/rules.mk >> + >> +sinclude $(obj).depend >> + >> +######################################################################### >> diff --git a/board/samsung/smdk5420/smdk5420.c >> b/board/samsung/smdk5420/smdk5420.c >> new file mode 100644 >> index 0000000..cf76455 >> --- /dev/null >> +++ b/board/samsung/smdk5420/smdk5420.c >> @@ -0,0 +1,253 @@ >> +/* >> + * Copyright (C) 2013 Samsung Electronics >> + * >> + * SPDX-License-Identifier: GPL-2.0+ >> + */ >> + >> +#include <common.h> >> +#include <fdtdec.h> >> +#include <asm/io.h> >> +#include <i2c.h> >> +#include <lcd.h> >> +#include <netdev.h> >> +#include <spi.h> >> +#include <asm/arch/board.h> >> +#include <asm/arch/cpu.h> >> +#include <asm/arch/dwmmc.h> >> +#include <asm/arch/gpio.h> >> +#include <asm/arch/mmc.h> >> +#include <asm/arch/pinmux.h> >> +#include <asm/arch/sromc.h> >> +#include <asm/arch/dp_info.h> >> +#include <power/pmic.h> >> + >> +DECLARE_GLOBAL_DATA_PTR; >> + >> +#ifdef CONFIG_USB_EHCI_EXYNOS >> +static int board_usb_vbus_init(void) >> +{ >> + struct exynos5_gpio_part1 *gpio1 = (struct exynos5_gpio_part1 *) >> + >> samsung_get_base_gpio_part1(); >> + >> + /* Enable VBUS power switch */ >> + s5p_gpio_direction_output(&gpio1->x2, 6, 1); >> + >> + /* VBUS turn ON time */ >> + mdelay(3); >> + >> + return 0; >> +} >> +#endif >> + >> +int exynos_init(void) >> +{ >> +#ifdef CONFIG_USB_EHCI_EXYNOS >> + board_usb_vbus_init(); >> +#endif >> + return 0; >> +} >> + >> +static int decode_sromc(const void *blob, struct fdt_sromc *config) >> +{ >> + int err; >> + int node; >> + >> + node = fdtdec_next_compatible(blob, 0, >> COMPAT_SAMSUNG_EXYNOS5_SROMC); >> + if (node < 0) { >> + debug("Could not find SROMC node\n"); >> + return node; >> + } >> + >> + config->bank = fdtdec_get_int(blob, node, "bank", 0); >> + config->width = fdtdec_get_int(blob, node, "width", 2); >> + >> + err = fdtdec_get_int_array(blob, node, "srom-timing", >> config->timing, >> + FDT_SROM_TIMING_COUNT); >> + if (err < 0) { >> + debug("Could not decode SROMC configuration Error: %s\n", >> + fdt_strerror(err)); >> + return -FDT_ERR_NOTFOUND; >> + } >> + return 0; >> +} >> + >> +int board_eth_init(bd_t *bis) >> +{ >> +#ifdef CONFIG_SMC911X >> + u32 smc_bw_conf, smc_bc_conf; >> + struct fdt_sromc config; >> + fdt_addr_t base_addr; >> + int node; >> + >> + node = decode_sromc(gd->fdt_blob, &config); >> + if (node < 0) { >> + debug("%s: Could not find sromc configuration\n", >> __func__); >> + return 0; >> + } >> + node = fdtdec_next_compatible(gd->fdt_blob, node, >> COMPAT_SMSC_LAN9215); >> + if (node < 0) { >> + debug("%s: Could not find lan9215 configuration\n", >> __func__); >> + return 0; >> + } >> + >> + /* We now have a node, so any problems from now on are errors */ >> + base_addr = fdtdec_get_addr(gd->fdt_blob, node, "reg"); >> + if (base_addr == FDT_ADDR_T_NONE) { >> + debug("%s: Could not find lan9215 address\n", __func__); >> + return -1; >> + } >> + >> + /* Ethernet needs data bus width of 16 bits */ >> + if (config.width != 2) { >> + debug("%s: Unsupported bus width %d\n", __func__, >> + config.width); >> + return -1; >> + } >> + smc_bw_conf = SROMC_DATA16_WIDTH(config.bank) >> + | SROMC_BYTE_ENABLE(config.bank); >> + >> + smc_bc_conf = SROMC_BC_TACS(config.timing[FDT_SROM_TACS]) | >> + SROMC_BC_TCOS(config.timing[FDT_SROM_TCOS]) | >> + SROMC_BC_TACC(config.timing[FDT_SROM_TACC]) | >> + SROMC_BC_TCOH(config.timing[FDT_SROM_TCOH]) | >> + SROMC_BC_TAH(config.timing[FDT_SROM_TAH]) | >> + SROMC_BC_TACP(config.timing[FDT_SROM_TACP]) | >> + SROMC_BC_PMC(config.timing[FDT_SROM_PMC]); >> + >> + /* Select and configure the SROMC bank */ >> + exynos_pinmux_config(PERIPH_ID_SROMC, config.bank); >> + s5p_config_sromc(config.bank, smc_bw_conf, smc_bc_conf); >> + return smc911x_initialize(0, base_addr); >> +#endif >> + return 0; >> +} >> > > Can the above two functions go into the board/samsung/common/board.c file > perhaps? > > Regards, > Simon > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > -- Regards, Rajeshwari Shinde _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot