On Thu, Nov 7, 2013 at 8:58 AM, Stefano Babic <sba...@denx.de> wrote: > Hi Giuseppe, > > On 07/11/2013 13:37, Giuseppe Pagano wrote: > >>>> +int mx6_rgmii_rework(struct phy_device *phydev) >>>> +{ >>>> + /* To advertise only 10 Mbs */ >>>> + phy_write(phydev, MDIO_DEVAD_NONE, 0x4, 0x61); >>>> + phy_write(phydev, MDIO_DEVAD_NONE, 0x9, 0x0c00); >>>> + >>> >>> Why only 10 Mb/s ? I think the Micrel 9031 allows 1Gb/s. >> >> I will check again, I remember this solves an issue present also in >> sabrelite board; but not sure. Maybe we can remove. > > Ok - I know the Nitrogen (aka sabrelite) is working fine with 100Mb, I > am worrying that you will constrain the udoo to 10Mb/s > >>>> + /* min rx data delay */ >>>> + ksz9021_phy_extended_write(phydev, >>>> + MII_KSZ9021_EXT_RGMII_RX_DATA_SKEW, 0x0); >>> >>> Is is 9021 or 9031 ? >> >> uDoo adopt a Micrel KSZ9031 phy. >> Most of the register address are common to ksz9021 and ksz9031, and have >> the same value. Maybe we should rename some variable to MII_KSZ90XX_... >> >> >>>> + >>>> + gpio_set_value(IMX_GPIO_NR(3, 23), 1); /* SABRE Lite PHY rst */ >>> >>> SABRE as comment is maybe wrong >>> >>>> +#define CONFIG_PHY_MICREL_KSZ9021 >>> >>> Ok, it is 9021 - please be consistent with the comments avoiding mixing >>> 9031 and 9021. >> >> No, it is 9031. I will create a new define. > > Mmmhh... I remember I did some work with KSZ9031 some times ago, let me see: > > http://patchwork.ozlabs.org/patch/271947/ > > Joe, what is the current status of that patchset ? Can you take a look > at it ?
Got it... I'll pull that in shortly. Thanks, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot