> -----Original Message----- > From: Detlev Zundel [mailto:[email protected]] > Sent: Thursday, April 23, 2009 6:00 PM > To: Ben Warren > Cc: Prafulla Wadaskar; [email protected]; Ashish Karkare; > Prabhanjan Sarnaik; Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v6] Marvell MV88E61XX Switch > Driver support > > Hi all, > > just an interesting side note: > > Statistics from v1 patch: > > board/Marvell/common/mv88e1116.c | 72 +++++++ > board/Marvell/common/mv88e60xx.c | 409 > +++++++++++++++++++++++++++++++++++++ > board/Marvell/common/mv88e61xx.c | 414 > ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 895 insertions(+), 0 deletions(-) create > mode 100644 board/Marvell/common/mv88e1116.c create mode > 100644 board/Marvell/common/mv88e60xx.c create mode 100644 > board/Marvell/common/mv88e61xx.c > > Statistics from v6 patch: > > drivers/net/phy/Makefile | 1 + > drivers/net/phy/mv88e61xx.c | 244 > +++++++++++++++++++++++++++++++++++++++++++ > drivers/net/phy/mv88e61xx.h | 143 +++++++++++++++++++++++++ > include/netdev.h | 1 + > 4 files changed, 389 insertions(+), 0 deletions(-) create > mode 100644 drivers/net/phy/mv88e61xx.c create mode 100644 > drivers/net/phy/mv88e61xx.h > > Now even without looking at the details, if this isn't a > *pretty* good example of what showing code and a review > process can do, then I really don't know. I really appreciate a quality review feedback and great usability of existing code to make this considerable difference.
Even you will find considerable reduced code size for my other upcoming patches. Thanks to everyone to make u-boot more structured... Regards.. Prafulla . . _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
