Hi Scott, On 11/21/2013 06:27 AM, Scott Wood wrote: > From: Prabhakar Kushwaha <[email protected]> > > nand_ecclayout is present in mtd.h at Linux. > Move this structure to mtd.h to comply with Linux. > > Also, increase the ecc placement locations to 640 to suport device having > writesize/oobsize of 8KB/640B. This means that the maximum oobsize has gone > up to 640 bytes and consequently the maximum ecc placement locations have > also gone up to 640. > > Changes from Prabhabkar's version (squashed into one patch to preserve > bisectability): > - Added _LARGE to MTD_MAX_*_ENTRIES > > This makes the names match current Linux source, and resolves > a conflict between > http://patchwork.ozlabs.org/patch/280488/ > and > http://patchwork.ozlabs.org/patch/284513/ > > The former was posted first and is closer to matching Linux, but > unlike Linux it does not add _LARGE to the names. The second adds > _LARGE to one of the names, and depends on it in a subsequent patch > (http://patchwork.ozlabs.org/patch/284512/). > > - Made max oobfree/eccpos configurable, and used this on tricorder, > alpr, ASH405, T4160QDS, and T4240QDS (these boards failed to build > for me without doing so, due to a size increase). > > On tricorder SPL, this saves 2576 bytes (and makes the SPL build > again) versus the new default of 640 eccpos and 32 oobfree, and > saves 336 bytes versus the old default of 128 eccpos and 8 oobfree. > > Signed-off-by: Prabhakar Kushwaha <[email protected]> > CC: Vipin Kumar <[email protected]> > [[email protected]: changes as described above] > Signed-off-by: Scott Wood <[email protected]> > Cc: Thomas Weber <[email protected]> > Cc: Matthias Fuchs <[email protected]> > Cc: Stefan Roese <[email protected]> > Cc: York Sun <[email protected]> > Cc: Tom Rini <[email protected]>
I don't have any affected board to test this on (maintained by myself), but this change looks reasonable. So: Reviewed-by: Stefan Roese <[email protected]> Thanks, Stefan _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
