Dear Jean-Christophe, In message <[email protected]> Ben Warren wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 15:49 Sun 12 Apr , David Brownell wrote: > > > >> From: David Brownell <[email protected]> > >> > >> Chips without the EMAC controller won't need the utilities > >> it uses to read an Ethernet address from EEPROM; so don't > >> include them needlessly. > >> > >> Use is_valid_ether() to validate the address from EEPROM. > >> All-zero addresses aren't the only invalid addresses. > >> A fully erased EEPROM returns all-ones, also invalid... > >> > >> Switch those Ethernet utilities to use "%pM" for printing > >> MAC addresses; and not say ROM when they mean EEPROM. > >> > >> Signed-off-by: David Brownell <[email protected]> > >> > Acked-by: Ben Warren <[email protected]> > > Looks fine > > > > Ben any comments? > > > > Best Regards, > > J. > > > Please pull this in with the other changes.
Is this in your queue? I would like to pull this soon, please. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] There's another way to survive. Mutual trust -- and help. -- Kirk, "Day of the Dove", stardate unknown _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
