Hi Jagan, > On Sun, Jan 19, 2014 at 2:06 AM, Marek Vasut <ma...@denx.de> wrote: >> On Saturday, January 18, 2014 at 09:06:31 PM, Jagannadha >> Sutradharudu Teki >> wrote: >>> - Used readable names for read/write command macros >>> - Added comments for the same >>> >>> Signed-off-by: Jagannadha Sutradharudu Teki <jaga...@xilinx.com> >>> Cc: Marek Vasut <ma...@denx.de> >>> Cc: Simon Glass <s...@chromium.org> >> >> Does this patch have any impact other than making the code harder to >> understand >> ? :-( >> >> What's the rationale for making the code more cryptic ? > > No issues I guess with the readability as each macro we can easily > understand. > like CMD_RD_QUAD --> command_read_quad > CMD_WR_PAGE --> command_write_page_program > > And this will minimize the macro length - good for in coding and more over > description is added in drivers/mtd/spi/sf_internal.h anyway.
Again I agree with Marek that readability of code is more important than saving a few characters while coding. This is especially true as editors can support you in coding (Emacs has lots of packages to help here for example). Cheers Detlev -- (7) It is always something (7a) (corollary). Good, Fast, Cheap: Pick any two (you can't have all three). -- The Twelve Networking Truths (RFC 1925) -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot