On 27 January 2014 08:53, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 01/26/2014 09:11 AM, Simon Glass wrote: >> Hi Stephen, >> >> On 24 January 2014 12:46, Stephen Warren <swar...@wwwdotorg.org >> <mailto:swar...@wwwdotorg.org>> wrote: >> >> From: Stephen Warren <swar...@nvidia.com <mailto:swar...@nvidia.com>> >> >> Tegra124's MMC controller is very similar to earlier SoC generations, >> and can be supported by the same driver. >> >> However, there are some non-backwards-compatible HW differences, and >> hence a new DT compatible value must be used to describe the HW. This >> patch updates the driver to support that new compatible value. >> >> That said, the HW differences are only relevant when enabling certain >> high-performance transfer modes. Since the driver is currently very >> simple and doesn't enable those modes, we don't actually need to address >> any of these HW differences in the code yet, hence the simple nature of >> this patch. >> >> Signed-off-by: Stephen Warren <swar...@nvidia.com >> <mailto:swar...@nvidia.com>> >> Acked-by: Pantelis Antoniou <pa...@antoniou-consulting.com >> <mailto:pa...@antoniou-consulting.com>> >> Tested-by: Thierry Reding <tred...@nvidia.com >> <mailto:tred...@nvidia.com>> >> >> >> As a general comment on this series (not this patch) there is is >> distressing amount of code duplication. It seems to me that this is just >> going to get more and more painful unless it is addressed. Removing and >> refactoring duplicated code is a difficult task. In particular defining >> almost identical clock functions in multiple files just doesn't seem >> like a good idea. > > Granted this is true. I am in the process of filing a bug to > de-duplicate the drivers. > >> Other than that this series looks good to me. > > Thanks. Is that an ack? :-)
I guess, particularly now that I know you've filed a bug :-) The series: Acked-by: Simon Glass <s...@chromium.org> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
