On 02/04/2014 09:35 PM, Tom Rini wrote: > On Tue, Feb 04, 2014 at 04:59:45PM +0100, Michal Simek wrote: > >> This patch is here because of: >> "arm: keep all sections in ELF file" >> (sha1: 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7) >> >> Our tools expect to have elf with only LOAD header. >> Without this fix also PHDR, INTERP and DYNAMIC headers >> are available in ELF. >> >> Signed-off-by: Michal Simek <[email protected]> > [snip] > > Two things.. > >> + /* >> + * Deprecated: this MMU section is used by pxa at present but >> + * should not be used by new boards/CPUs. >> + */ >> + . = ALIGN(4096); >> + .mmutable : { >> + *(.mmutable) >> + } > > You don't need this do you? If not, drop it..
I don't need it.
>
> [snip]
>> + /DISCARD/ : { *(.dynsym) }
>> + /DISCARD/ : { *(.dynbss*) }
>> + /DISCARD/ : { *(.dynstr*) }
>> + /DISCARD/ : { *(.dynamic*) }
>> + /DISCARD/ : { *(.plt*) }
>> + /DISCARD/ : { *(.interp*) }
>> + /DISCARD/ : { *(.gnu*) }
>> + /DISCARD/ : { *(.ARM.exidx*) }
>> + /DISCARD/ : { *(.gnu.linkonce.armexidx.*) }
>
> Here is the difference between your linker script and the main ARM one.
> Please add a comment block that explains that you need to discard more
> sections because the user is expected to pass this image on to tools
> that require them to be dropped so it's clear why there is this delta
> between the scripts. Thanks!
Fixed in v2.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
