>-----Original Message----- >From: Heiko Schocher [mailto:[email protected]] >Sent: Monday, March 31, 2014 1:24 AM >To: Karicheri, Muralidharan >Cc: Rini, Tom; [email protected] >Subject: Re: [U-Boot] [PATCH v4 6/9] i2c, davinci: convert driver to new >mutlibus/mutliadapter framework > >Hello Mruali, > Heiko,
Thanks for reviewing this. See below for my response. BTW, there is a Typo, it should have been Hello Murali, :) >Am 27.03.2014 16:59, schrieb Murali Karicheri: >> From: Vitaly Andrianov<[email protected]> >> >> - add davinci driver to new multibus/multiadpater support >> - adapted all config files, which uses this driver >> >> Signed-off-by: Vitaly Andrianov<[email protected]> >> Signed-off-by: Murali Karicheri<[email protected]> >> --- >> arch/arm/cpu/arm926ejs/davinci/dm355.c | 2 +- >> arch/arm/cpu/arm926ejs/davinci/dm365.c | 2 +- >> arch/arm/cpu/arm926ejs/davinci/dm644x.c | 2 +- >> arch/arm/cpu/arm926ejs/davinci/dm646x.c | 2 +- >> drivers/i2c/Makefile | 2 +- >> drivers/i2c/davinci_i2c.c | 401 >> ++++++++++++++++++------------- >> drivers/i2c/davinci_i2c.h | 27 ++- >> include/configs/cam_enc_4xx.h | 8 +- >> include/configs/da830evm.h | 8 +- >> include/configs/da850evm.h | 8 +- >> include/configs/davinci_dm355evm.h | 8 +- >> include/configs/davinci_dm355leopard.h | 8 +- >> include/configs/davinci_dm365evm.h | 8 +- >> include/configs/davinci_dm6467evm.h | 8 +- >> include/configs/davinci_dvevm.h | 8 +- >> include/configs/davinci_schmoogie.h | 8 +- >> include/configs/davinci_sffsdr.h | 8 +- >> include/configs/davinci_sonata.h | 8 +- >> include/configs/ea20.h | 6 +- >> include/configs/enbw_cmc.h | 8 +- >> 20 files changed, 305 insertions(+), 235 deletions(-) > >This is your v4 post ... some sort of history, what has changed would be nice >... > The history is maintained for the series that is part of the cover letter. I have reproduced it below for your convenience. Change history: v4 - Added multibus support in i2c driver. Tested only on Keystone - Added comments to fdt patch v3 - Seperated network driver patches from the original series and and is now a different set as there are outstanding issues to be discussed and sorted out. Also the original series is ready for merge to upstream IMO. - Review comments incorporated. Following are the major comments addressed - Added KBUILD target for u-boot-spi.gph - Added bootup and flashing instructions in README - Cleaned up manually replacing #define <tab> with #define <space> - Cleaned up k2hk_evm.h include file to remove unnecessary options v2 - Review comments incorporated. Following are major comments addressed - split network driver to navigator driver + ethernet driver - replaced register base + offset implemenation with struct based register access implementation - Added Readme for NAND no subpage write option - re-use code for davinci i2c driver on keystone2 with updates - clock-k2hk.c merged to clock.c - currently keeping board specific getclk() command. See the thread for the rational. - Added update to davinci spi driver to re-use on keystone v1 - added separate patch for sorting tools/Makefile entries - reworked gpimage patch to allow more re-use across omapimage/gpimage - dropped patch related to ubifs file size - added keystone SoC and K2HK EVM support v0 - preparatory patch for keystone >[...] >> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile index >> 36d5e5f..fd1cb11 100644 >> --- a/drivers/i2c/Makefile >> +++ b/drivers/i2c/Makefile >> @@ -6,7 +6,7 @@ >> # >> >> obj-$(CONFIG_BFIN_TWI_I2C) += bfin-twi_i2c.o >> -obj-$(CONFIG_DRIVER_DAVINCI_I2C) += davinci_i2c.o >> +obj-$(CONFIG_SYS_I2C_DAVINCI) += davinci_i2c.o > >please keep lists sorted. Are you asking me to sort the entire Makefile based on file name? davinci_i2c.o is at the correct alphabetical position right now. Or are you expecting this to be sorted based on CONFIG_SYS_<xxx> ? If so, I could change as obj-$(CONFIG_SYS_I2C) += i2c_core.o obj-$(CONFIG_SYS_I2C_DAVINCI) += davinci_i2c.o obj-$(CONFIG_SYS_I2C_FSL) += fsl_i2c.o obj-$(CONFIG_SYS_I2C_FTI2C010) += fti2c010.o Please confirm. If sort by file name, then I am missing something. >[...] > >Rest looks Ok for me ... if checkpatch drops no errors and warnings and MAKEALL >compiles clean ;-) > Yes. I did it and no errors/warning. ./MAKEALL ran fine too. >bye, >Heiko >-- >DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel >HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
