Hi Masahiro, On 27 March 2014 22:42, Masahiro Yamada <[email protected]> wrote:
> Hi Simon, > > > > Collect all Signed-off-by tags in a commit and make sure that there are > > no duplicates. > > > > Signed-off-by: Simon Glass <[email protected]> > > > I have a change request about this patch. > > It is true this patch avoids duplication, but > it changes the order *-by: credits. > > > > For example, assume something like this in my git-log > > blah blah blah > > Signed-off-by: Masahiro Yamada <[email protected]> > Reported-by: For Bar <[email protected]> > > > > Patman changes it to > > blah blah blah > > Reported-by: For Bar <[email protected]> > Signed-off-by: Masahiro Yamada <[email protected]> > > > > I want Patman to touch *-by: credits only when it is really necessary. > [1] when adding a missing Signed-off-by: > [2] when deleting redundant Signed-off-by: > > > Yes I agree that is better - I will update the patch and resend as v2. Regards, Simon
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
