On 09:42 Sun 10 May , Dirk Behme wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: >> move s3c44b0 to arch_cpu_init and as noone use cpu_init remove it >> >> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]> > > Cortex-A8 (OMAP3) part > > Acked-by: Dirk Behme <[email protected]> > > Just a minor _question_ for an other board below: > >> diff --git a/cpu/s3c44b0/cpu.c b/cpu/s3c44b0/cpu.c >> index 7ef4a1f..bca38f8 100644 >> --- a/cpu/s3c44b0/cpu.c >> +++ b/cpu/s3c44b0/cpu.c >> @@ -32,7 +32,7 @@ >> #include <command.h> >> #include <asm/hardware.h> >> -int cpu_init (void) >> +int arch_cpu_init (void) >> { >> icache_enable(); >> > > Would encapsulating this new arch_cpu_init() with an additional > CONFIG_ARCH_CPU_INIT, e.g. no as this code is supposed to be always enable > > #if defined(CONFIG_ARCH_CPU_INIT) > int arch_cpu_init (void) > { > > (like below) help to avoid issues if cpu/s3c44b0/cpu.c would be compiled > without CONFIG_ARCH_CPU_INIT enabled? why? this is where the s3c44 enable the icache
Best Regards, J. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
