On Wed, May 14, 2014 at 01:25:45PM +0200, Michal Simek wrote: > Hi Tom, > > On 05/02/2014 04:10 PM, Michal Simek wrote: > > From: Siva Durga Prasad Paladugu <siva.durga.palad...@xilinx.com> > > > > Added support to load a bitstream image in chunks by reading it in > > chunks from SD/MMC. > > Command format: > > loadfs [dev] [address] [image size] [blocksize] <interface> > > [<dev[:part]>] <filename> > > Example: fpga loadfs 0 1000000 3dbafc 4000 mmc 0 fpga.bin > > > > Signed-off-by: Siva Durga Prasad Paladugu <siva...@xilinx.com> > > Signed-off-by: Michal Simek <michal.si...@xilinx.com> > > --- > > > > We have tested just FAT case but I am sending this as RFC > > to give some inputs from you. > > The reason for this command is that when u-boot running > > from OCM on zynq there is just 192kB for u-boot itself > > and there must be an option to load bitstream to PL > > because there full DDR controller. > > Bitstreams are bigger and bigger and reading it with chunks > > is only one way how to do it. > > This is also necessary to do it for u-boot SPL when > > we add fpga support there. > > > > The question is if this is the way how to extend fpga command > > because loadfs should be fpga subcommand. > > > > This patch is based on this branch. > > http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/xnext/zynq > > > > Thanks for your comments, > > Michal > > > > --- > > common/cmd_fpga.c | 41 +++++++++++++++++++++ > > drivers/fpga/fpga.c | 28 ++++++++++++++ > > drivers/fpga/xilinx.c | 16 ++++++++ > > drivers/fpga/zynqpl.c | 85 > > +++++++++++++++++++++++++++++++++++++++++++ > > include/configs/zynq-common.h | 1 + > > include/fpga.h | 9 +++++ > > include/xilinx.h | 3 ++ > > 7 files changed, 183 insertions(+) > > Are you OK with this patch? > I would expect that you will have some comments regarding this because it is > command extension. > If you are OK with this I will add it to my next fpga pull request with > partial bitstream support.
It's a new subcommand, seems like a fine idea. Can we leverage FS_TYPE_ANY so it's not limited to FAT? -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot