On 05/22/2014 01:18 AM, Stephen Warren wrote: > On 05/20/2014 11:40 PM, Jaehoon Chung wrote: >> Hi, Stephen. >> >> i didn't apply your patch. Which repository do you use? > > It's based on u-boot.git master branch. The latest u-boot-mmc.git master > branch is already included in that branch, and it looks like some > changes have been applied to cmd_mmc.c in u-boot/master that aren't in > u-boot-mmc/master.
I have pulled the latest u-boot.git, but it didn't apply this patch. If i missed something, let me know plz. > >> Well, if you want to check, can be used "if (mmc_init(mmc))". >> >> And i'm not sure whether this code is really need or not. > > Why not? This code is required to solve the problem described in the > commit description: I will try to reproduce the problem described in the commit-msg. Because, i didn't reproduce it, so i'm not sure. But to control the return value, it's reasonable, right? Best Regards, Jaehoon Chung > >> On 05/21/2014 01:57 AM, Stephen Warren wrote: >>> From: Bryan Wu <[email protected]> >>> >>> mmc dev ${devnum} will return 0 as success even if there is no card >>> inserted. Booting script like tegra-common-post.h will call mmc dev >>> ${devnum} to check the mmc device status, it always return 0 even if >>> mmc_init() fails. > > > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
