Re: [U-Boot] [PATCHv2 3/4] omap3: replace all instances of gpmc config struct by one global

Tue, 12 May 2009 16:09:10 -0700 

> diff --git a/cpu/arm_cortexa8/omap3/mem.c b/cpu/arm_cortexa8/omap3/mem.c
> index aa15f94..079c848 100644
> --- a/cpu/arm_cortexa8/omap3/mem.c
> +++ b/cpu/arm_cortexa8/omap3/mem.c
> @@ -41,6 +41,8 @@ unsigned int boot_flash_sec;
>  unsigned int boot_flash_type;
>  volatile unsigned int boot_flash_env_addr;
>  
> +struct gpmc *gpmc_cfg;
please do not expose it directly
please use a function to get it
> +
>  #if defined(CONFIG_CMD_NAND)
>  static u32 gpmc_m_nand[GPMC_MAX_REG] = {
>       M_NAND_GPMC_CONFIG1,
> @@ -51,8 +53,6 @@ static u32 gpmc_m_nand[GPMC_MAX_REG] = {
>       M_NAND_GPMC_CONFIG6, 0
>  };
>  
Best Regards,
J.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to