Hi Albert, On Mon, 9 Jun 2014 10:35:06 +0200 Albert ARIBAUD <[email protected]> wrote:
> Hi Masahiro, > > On Mon, 09 Jun 2014 16:36:56 +0900, Masahiro Yamada > <[email protected]> wrote: > > > Hi Albert, > > > > On Mon, 9 Jun 2014 09:14:11 +0200 > > Albert ARIBAUD <[email protected]> wrote: > > > > > Hi Masahiro, > > > > > > On Mon, 26 May 2014 19:43:50 +0900, Masahiro Yamada > > > <[email protected]> wrote: > > > > > > > Commit 41623c91 moved exception handling to arch/arm/lib/vectors.S, > > > > breaking CONFIG_USE_IRQ feature. > > > > > > > > If CONFIG_USE_IRQ is enabled, undefined reference error occurs. > > > > > > > > arch/arm/lib/built-in.o: In function `interrupt_init': > > > > arch/arm/lib/interrupts.c:37: undefined reference to `IRQ_STACK_START' > > > > arch/arm/lib/interrupts.c:37: undefined reference to `FIQ_STACK_START' > > > > make: *** [u-boot] Error 1 > > > > > > > > Because arch/arm/lib/vectors.S includes references to > > > > CONFIG_SYS_DV_NOR_BOOT_CFG and CONFIG_USE_IRQ, it must include > > > > <config.h>. > > > > > > I routinely build all of ARM (32-bit) and AARCH64 (64-bit) targets and > > > make sure all of them build properly, and concerning CONFIG_USE_IRQ, I > > > even have a branch set to remove this option since a > > > > > > git grep CONFIG_USE_IRQ | grep -vE \ > > > '(#define|#ifdef|#ifndef|#if.*defined|#undef|#endif)' > > > > > > shows that it is defined nowhere in our code. > > > > > > Which source code are you using? > > > > Out-of-tree board support code, maintained locally. > > Then I'm afraid you'll have to keep this patch local too -- and note > that I am considering overhauling, and possibly removing entirely, > CONFIG_USE_IRQ (my grep command comes from my WIP on this). BTW, I don't think it is a good idea to postpone fixing the problem, depending on the future development. - We should support features which exist in the code base. (I mean if it is referenced, even without definition) - If we are not willing to support the feature any more, it should be removed immediately from the code base. In this case, CONFIG_USE_IRQ is still referenced and if you don't remove it now, we must maintain that macro. Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
