[U-Boot] [PATCH v2 4/4] usb/gadget: fastboot: minor cleanup

[Steve Rae]

- update static function
- additional debugging statements

Signed-off-by: Steve Rae <s...@broadcom.com>
---

Changes in v2:
- new in v2

 drivers/usb/gadget/f_fastboot.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
index 89c2d3e..3e6e47f 100644
--- a/drivers/usb/gadget/f_fastboot.c
+++ b/drivers/usb/gadget/f_fastboot.c
@@ -293,7 +293,7 @@ static int fastboot_add(struct usb_configuration *c)
 }
 DECLARE_GADGET_BIND_CALLBACK(usb_dnl_fastboot, fastboot_add);
 
-int fastboot_tx_write(const char *buffer, unsigned int buffer_size)
+static int fastboot_tx_write(const char *buffer, unsigned int buffer_size)
 {
        struct usb_request *in_req = fastboot_func->in_req;
        int ret;
@@ -338,6 +338,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request 
*req)
        strcpy(response, "OKAY");
        strsep(&cmd, ":");
        if (!cmd) {
+               printf("%s: missing var\n", __func__);
                fastboot_tx_write_str("FAILmissing var");
                return;
        }
@@ -358,6 +359,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request 
*req)
                else
                        strcpy(response, "FAILValue not set");
        } else {
+               printf("%s: unknown variable: %s\n", __func__, cmd);
                strcpy(response, "FAILVariable not implemented");
        }
        fastboot_tx_write_str(response);
@@ -531,10 +533,12 @@ static void rx_handler_command(struct usb_ep *ep, struct 
usb_request *req)
                }
        }
 
-       if (!func_cb)
+       if (!func_cb) {
+               printf("%s: unknown command: %s\n", __func__, cmdbuf);
                fastboot_tx_write_str("FAILunknown command");
-       else
+       } else {
                func_cb(ep, req);
+       }
 
        if (req->status == 0) {
                *cmdbuf = '\0';
-- 
1.8.5

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot