Dear Pavel,
In message <[email protected]> you wrote:
>
> > > Ok, would it be acceptable to change 'count not set' message to 'could
> > > not set or invalid address' and print the address as well?
> >
> > Print the address - if it is not set? I think we should provide useful
> > error messages. Either the address has not been set, then we should
> > say so, or it is invalid, then we should say that.
>
> Well, it may be unset (00:00:...) or it may be invalid (b2:a3:...).
The address being not set at all, and it being set to
00:00:00:00:00:00, are two totally different cases, In the former,
it's, well, not set, and in the latter it is set to an invalid value.
> I think I do not understand you correctly. Yes, we should provide
> useful error messages, and current one is untrue and confusing.
>
> Can you suggest a patch or messages you'd like to see?
If not set at all:
"ERROR: eth?addr not set"
If set to an illegal value:
"ERROR: eth?addr=XX:XX:XX:XX:XX:XX illegal value"
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
Plans break down. You cannot plan the future. Only presumptuous fools
plan. The wise man _steers_. - Terry Pratchett, _Making_Money_
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
