Dear Stefano & Heiko, In message <[email protected]> you wrote: > > > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c > > new file mode 100644 > > index 0000000..c70e150 > > --- /dev/null > > +++ b/drivers/pwm/pwm-imx.c > > @@ -0,0 +1,109 @@ > > +/* > > + * (C) Copyright 2014 > > + * Heiko Schocher, DENX Software Engineering, [email protected]. > > + * > > + * Basic support for the pwm modul on imx6. > > + * > > + * Based on linux:drivers/pwm/pwm-imx.c > > + * from > > + * Sascha Hauer <[email protected]> > > + * > > + * SPDX-License-Identifier: GPL-2.0+
Is this really GPL-2.0+ ? The Linux driver is definitely GPL-2.0 only! > Nice ! Should we also add in the commit message that the code is > directly taken from kernel driver ? Not should - must! Exact reference including commit ID is mandatory! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] If you're out of tree, you don't exist. - David Woodhouse in <[email protected]> _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
