On Mon, 21 Jul 2014 20:51:12 +0100 Ian Campbell <[email protected]> wrote:
> On Fri, 2014-07-18 at 19:23 +0300, Siarhei Siamashka wrote: > > All the known Allwinner A10/A13/A20 devices are using just single rank > > DDR3 memory. So don't pretend that we support DDR2 or more than one > > rank, because nobody could ever test these configurations for real and > > they are likely broken. Support for these features can be added back > > in the case if such hardware actually exists. > > > + if (para->type != DRAM_MEMORY_TYPE_DDR3 || para->rank_num != 1) > > + return 0; > > Can we not go further and remove these fields from the para struct too? Right now the DRAM patchset keeps backwards compatibility with the old 'dram_para' settings. This is intended to ensure that it is a drop-in replacement for the old code and make the transition easier. The fields can be removed at any time later as a cosmetic fix. -- Best regards, Siarhei Siamashka _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
