On Sun, Jul 13, 2014 at 12:27:41PM -0600, Simon Glass wrote: > Change the Exynos serial driver to work with driver model and switch over > all Exynos5 boards to use it. > > Signed-off-by: Simon Glass <[email protected]>
So, maybe it's just the way the diff was generated, but did you re-order the functions in the file? Trying to see for example how 'set_brg' changed here isn't easy since it used to be at the top, but is now near the bottom? And other functions too perhaps. IOW, assuming the function locations changed in the driver, can you re-shuffle things so the function order is the same? This will help both with review and future conversions I think. Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
