On 07/08/14 16:49, Marek Vasut wrote:
On Thursday, August 07, 2014 at 03:05:28 PM, Nikita Kiryanov wrote:
Currently, CONFIG_SPL_SPI_* #defines are used for controlling SPI boot in
SPL. These #defines do not allow the user to select SPI mode for the SPI
flash (there's no CONFIG_SPL_SPI_MODE, so the SPI mode is hardcoded in
spi_spl_load.c), and duplicate information already provided by
CONFIG_SF_DEFAULT_* #defines.

Kill CONFIG_SPL_SPI_*, and use CONFIG_SF_DEFAULT_* instead.

Cc: Jagannadha Sutradharudu Teki <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: Sudhakar Rajashekhara <[email protected]>
Cc: Lokesh Vutla <[email protected]>
Cc: Vitaly Andrianov <[email protected]>
Cc: Lars Poeschel <[email protected]>
Cc: Bo Shen <[email protected]>
Cc: Hannes Petermaier <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Marek Vasut <[email protected]>
Signed-off-by: Nikita Kiryanov <[email protected]>

Oh, right. This doesn't collide with the Kconfig work, does it ?

It does not.
(No "config CONFIG_SPL_SPI_*", nor "config CONFIG_SF_DEFAULT_*" in any Kconfig files)


Otherwise, I see this as OK,

Reviewed-by: Marek Vasut <[email protected]>

Best regards,
Marek Vasut

_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to