Hello Nitin, On Sun, Aug 31, 2014 at 3:26 PM, <nitin.g...@freescale.com> wrote: > From: Nitin Garg <nitin.g...@freescale.com> > > Signed-off-by: Nitin Garg <nitin.g...@freescale.com>
I agree with the patch, two remarks only: Please use the rename tracking of Git so it is much easier to see what changed between the files. One easy way to do that is to add, to your $HOME/.gitconfig: [diff] renames = true The second remark is about the commit log. Please rework it to comply to the conventions[1] 1. http://www.denx.de/wiki/U-Boot/Patches#Commit_message_conventions For example, I'd rewrite this commit log as: imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir Move board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg to board/freescale/mx6sabresd/mx6q_4x_mt41j128.cfg as this is was designed for the mx6sabresd board. This also updates the cgtqmx6qeval which makes use of this configuration. Signed-off-by: ... -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot