Vadim, On Wed, Sep 3, 2014 at 4:00 PM, Vadim Bendebury <vben...@chromium.org> wrote: > On Wed, Sep 3, 2014 at 3:14 PM, Doug Anderson <diand...@chromium.org> wrote: >> Vadim, >> >> On Wed, Sep 3, 2014 at 12:16 PM, Vadim Bendebury <vben...@chromium.org> >> wrote: >>> For an occasional user of patman some failures are not obvious: for >>> instance when checkpatch reports warnings, the dry run still reports >>> that the email would be sent. If it is not dry run, the warnings are >>> shown on the screen, but it is not clear that the email was not sent. >>> >>> Add some code to report failure to send email explicitly. >>> >>> Tested by running the script on a patch with style violations, >>> observed error messages in the script output. >>> >>> Signed-off-by: Vadim Bendebury <vben...@chromium.org> >>> --- >>> >>> tools/patman/patman.py | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/patman/patman.py b/tools/patman/patman.py >>> index c60aa5a..0163ccd 100755 >>> --- a/tools/patman/patman.py >>> +++ b/tools/patman/patman.py >>> @@ -154,13 +154,19 @@ else: >>> >>> # Email the patches out (giving the user time to check / cancel) >>> cmd = '' >>> - if ok or options.ignore_errors: >>> + its_a_go = ok or options.ignore_errors >>> + if its_a_go: >>> cmd = gitutil.EmailPatches(series, cover_fname, args, >>> options.dry_run, not options.ignore_bad_tags, cc_file, >>> in_reply_to=options.in_reply_to) >>> + else: >>> + print col.Color(col.RED, >>> + "Not sending emails due to checkpatch >>> errors/warnings") >> >> Technically it could be due to other problems, too (like errors applying). > > good point, what wording would you suggest?
You don't think that just removing the word "checkpatch" is enough. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot