Dear Prafulla Wadaskar,

In message <[email protected]> you wrote:
> Reference:
> http://plugcomputer.org/
> http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support
> 
> This patch is tested for-
> 1. Boot from DRAM/NAND flash
> 2. File transfer using tftp
> 3. NAND flash read/write/erase
> 4. Linux kernel and RFS Boot from NAND

Entry in MAINTAINERS missing.

...
> +/*
> + * Commands configuration
> + */
> +#define CONFIG_CMD_ENV
> +#define CONFIG_CMD_RUN
> +#define CONFIG_CMD_LOADB
> +#define CONFIG_CMD_NET
> +#define CONFIG_CMD_AUTOSCRIPT
> +#define CONFIG_CMD_MEMORY
> +#define CONFIG_CMD_BOOTD
> +#define CONFIG_CMD_SAVEENV
> +#define CONFIG_CMD_NAND

Please sort such lists.

...
> +#define CONFIG_MTDPARTS                      "orion_nand:512k(uboot),"       
> \
> +     "1...@4m(psm),3...@1m(kernel),1...@5m(rootfs) rw\0"

Is this weird partition setup intentional?

...
> +/*
> + * Ethernet Driver configuration
> + */
> +#ifdef CONFIG_CMD_NET
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_PING

I prefer to have all command related definition close together. Move
up?

> +#define CONFIG_NETCONSOLE    /* include NetConsole support   */
> +#define CONFIG_NET_MULTI     /* specify more that one ports available */
> +#define      CONFIG_MII              /* expose smi ove miiphy interface */
> +#define CONFIG_KIRKWOOD_EGIGA        /* Enable kirkwood Gbe Controller 
> Driver */
> +#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN      /* detect link using phy */
> +#define CONFIG_KIRKWOOD_EGIGA_PORTS  {1,0}   /* enable port 0 only */
> +#define CONFIG_PHY_BASE_ADR  0
> +#define CONFIG_ENV_OVERWRITE /* ethaddr can be reprogrammed */
> +#endif /* CONFIG_CMD_NET */
...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
Totally illogical, there was no chance.
        -- Spock, "The Galileo Seven", stardate 2822.3
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to