On 28 September 2014 09:15, Simon Glass <s...@chromium.org> wrote: > On 28 September 2014 07:52, Masahiro Yamada <yamad...@jp.panasonic.com> wrote: >> The function uclass_add() checks uc_drv->ops as follows: >> >> if (uc_drv->ops) { >> dm_warn("No ops for uclass id %d\n", id); >> return -EINVAL; >> } >> >> It seems odd because it warns "No ops" when uc_drv->ops has >> non-NULL pointer. (Looks opposite.) >> >> Anyway, most of UCLASS_DRIVER entries have no .ops member. >> This check makes no sense. >> >> Signed-off-by: Masahiro Yamada <yamad...@jp.panasonic.com> > > Acked-by: Simon Glass <s...@chromium.org>
Applied to u-boot-dm/next, thanks! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot