Hi Simon,
On Wed, 22 Oct 2014 21:31:22 -0600 Simon Glass <[email protected]> wrote: > > diff --git a/include/configs/ph1_sld8.h b/include/configs/ph1_sld8.h > > index 41e2299..1062aac 100644 > > --- a/include/configs/ph1_sld8.h > > +++ b/include/configs/ph1_sld8.h > > @@ -28,9 +28,7 @@ > > * SoC UART : enable CONFIG_UNIPHIER_SERIAL > > * On-board UART: enable CONFIG_SYS_NS16550_SERIAL > > */ > > -#if 1 > > -#define CONFIG_UNIPHIER_SERIAL > > -#else > > +#if 0 > > #define CONFIG_SYS_NS16550_SERIAL > > #endif > > Why not just remove this code? There are two types of UART ports on our boards - On-chip UART core - Some of our boards also have a on-board 16550 UART. For those boards, user can select a favorate UART port. In the future, CONFIG_SYS_NS16550_SERIAL also should be moved to Kconfig to allow users to enable/disable each UART driver. I know this code is silly. The only excuse I could find was just a reminder of TODO item for me. Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
