Hi, On 10/29/2014 06:45 AM, Masahiro Yamada wrote: > Hi Hans, > > > On Fri, 24 Oct 2014 10:11:25 +0200 > Hans de Goede <hdego...@redhat.com> wrote: > >> Hi, >> >> On 10/24/2014 10:07 AM, Chen-Yu Tsai wrote: >>> The defconfig for Ippo-q8h-v5 was incorrectly committed as >>> "Ippo_q8h". This patch renames it correctly, as well as >>> correct a typo in my name in the maintainers listing. >>> >>> Signed-off-by: Chen-Yu Tsai <w...@csie.org> >>> --- >>> >> >> Thats fast. >> >>> Feel free to squash this into >>> >>> 7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig >> >> I'm afraid it is too late as I've already send out a pull-req >> with that commit in it. If I had know you would be this fast I would >> have waited 5 minutes :) >> >> Ah well. This fix is: >> >> Acked-by: Hans de Goede <hdego...@redhat.com> >> >> And queued up in u-boot-sunxi/next. >> > > > No. This is almost like a bug fix. > > Please apply it on master and send a PR to Tom asap. > > Without this patch, tools/genboardscfg.py spits warnings: > > $ tools/genboardscfg.py > WARNING: no status info for 'Ippo_q8h' > WARNING: no maintainers for 'Ippo_q8h'
IMHO these 2 innocent warnings are not a good reason 2 rush out a fix, and since the fix actually was buggy (which I've already fixed in u-boot-sunxi/next but the original fix was no good), it is a good thing this was not rushed out. Regards, Hans _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot