> > Boards using the TWL4030 regulator may not all use the LDOs the same way
> > (e.g. MMC2 power can be controlled by another LDO than VMMC2).
> > This delegates TWL4030 MMC power initializations to board-specific
> > functions,
> > that may still call twl4030_power_mmc_init for the default behavior.
> [snip]
> > +int board_mmc_power_init(void)
> > +{
> > +#if defined(CONFIG_TWL4030_POWER)
> > + twl4030_power_mmc_init();
> > + mdelay(100); /* ramp-up delay from Linux code */
> > +#endif
> > + return 0;
> > +}
> > #endif
>
> I think we can do away with the #if defined(CONFIG_TWL4030_POWER) part
> here since all of these boards will fail pretty spectacularly without
> that being set and if someone does remove that a link error is better
> than a crazy runtime problem.That makes sense, I'll do that in v5. > [snip] > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > > index 5b0c302..6e93a07 100644 > > --- a/drivers/mmc/omap_hsmmc.c > > +++ b/drivers/mmc/omap_hsmmc.c > > @@ -130,12 +130,7 @@ static unsigned char mmc_board_init(struct mmc *mmc) > > pbias_lite = readl(&t2_base->pbias_lite); > > pbias_lite &= ~(PBIASLITEPWRDNZ1 | PBIASLITEPWRDNZ0); > > writel(pbias_lite, &t2_base->pbias_lite); > > -#endif > > -#if defined(CONFIG_TWL4030_POWER) > > - twl4030_power_mmc_init(); > > - mdelay(100); /* ramp-up delay from Linux code */ > > -#endif > > -#if defined(CONFIG_OMAP34XX) > > + > > writel(pbias_lite | PBIASLITEPWRDNZ1 | > > PBIASSPEEDCTRL0 | PBIASLITEPWRDNZ0, > > &t2_base->pbias_lite); > > Since it's not clear from the context here, it's OK to drop the check on > CONFIG_OMAP34XX here since there's already a test on it above where diff > cut us off? Thanks! Indeed, that's the case (not sure this was actually more of a question than a statement). Thanks for the review! -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution Website: http://www.replicant.us/ Redmine: http://redmine.replicant.us/
signature.asc
Description: This is a digitally signed message part
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
