Hello Menon, Menon, Nishanth wrote: >> -----Original Message----- >> From: Peter Tyser [mailto:[email protected]] >> Sent: Wednesday, June 10, 2009 11:26 AM >>>>>>> --- a/drivers/i2c/twl4030_i2c.c >>>>>> All other drivers in drivers/i2c are host adapter drivers. Ie they >>>>>> implement i2c_read(), i2c_write(), i2c_probe(), and i2c_init(). >> The >>>>>> twl4030_i2c.c driver doesn't seem to fit this mold. Perhaps it >> would >>>> be >>>>>> better placed in drivers/misc or a new drivers/power directory >> similar >>>>>> to Linux? >>>>> This function probably belongs to board/omap3/common/power.c -> or >> even >>>> better to the board file itself? >>>> >>>> I was about to mention the opposite ;) >>>> >>>> Jean-Christophe asked to move the code from power.c to driver >> directory >>>> http://lists.denx.de/pipermail/u-boot/2009-May/052400.html >>>> >>>> If you follow above discussion, I was fine with power.c. If we get now >>>> a twl4030_i2c.c, we should merge the code from power.c into it, too >>>> (where ever it will be located and named, then). >>>> >>> This IMHO is the right approach -> but the real question is where in >> drivers/ directory? How about drivers/i2c/chips and moving the current >> drivers/i2c/* to drivers/i2c/busses - following the kernel organization? >> >> I'd vote against creating a drivers/i2c/chips directory. I believe this >> directory is deprecated in the Linux kernel and they'd prefer drivers be >> put in the proper driver/<subsystem> directory. I'd vote to follow this >> convention in U-Boot too. >> >> I'm not familiar with the device or what features you plan on supporting >> so I can't speak to whether it'd fit better in drivers/power, >> drivers/misc, somewhere omap3/board specific, etc. >> > How about this: > > Regarding Dirk's and Heiko's comment: > A) How about board/omap3/common/power.c to drivers/power/twl4030.c
I don;t know, if this "board/omap3/common/power.c" is identical with twl4030 ... ? > On patch C: > B) introduce a new header in include/twl4030.h from Tom's patch > Remove drivers/i2c/twl4030_i2c.c from the patch instead add: > #define TWLL4030_READ_U8(MODULE, VAL,REG)\ > i2c_read((MODULE), (REG), 1, (VAL), 1) > #define TWLL4030_WRITE_U8(MODULE, VAL,REG)\ > i2c_read((MODULE), (REG), 1, (VAL), 1) > to include/twl4030.h in the patch. Maybe an option ... thats why I think it is no i2c driver ... > C) on [PATCH 3/4] ZOOM2 Add power reset button > The change should go to corresponding board file -> for zoom1 or zoom2. or in "drivers/power/twl4030.c", if it is for all zoom* boards identical. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
