Dear Roger,

In message <[email protected]> you wrote:
> From: "Meier, Roger" <[email protected]>
> 
> Goal:
>   - building all variants of U-Boot with multiple configurations
>   - code quality checks and metrics
>   - https://travis-ci.org/u-boot/u-boot/builds
> 
> Changes for v3:
...
> Changes for v2:
...

This changelog should go below the "---" separator line

> +    # search for HACK within source tree and ignore HACKKIT board
> +    - env:
> +        - TEST_CMD="grep -r HACK *"

I don't see how you ignore MACH_TYPE_HACKKIT etc. here?  Is this
eventually sstill missing?


Except for these two minor comments:  thanks a lot for this extremly
valuable contribution.

Acked-by: Wolfgang Denk <[email protected]>

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
The one who says it cannot be done should never interrupt the one who
is doing it.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to