On Sat, Oct 11, 2014 at 06:42:51PM +0200, Marek Vasut wrote: > Printing u32 with %02x is just a bad idea, fix it. > > Signed-off-by: Marek Vasut <[email protected]> > Cc: Kyungmin Park <[email protected]> > Cc: Lukasz Majewski <[email protected]> > Cc: Minkyu Kang <[email protected]> > Cc: Scott Wood <[email protected]> > Cc: Vladimir Zapolskiy <[email protected]> > --- > drivers/mtd/nand/s3c2410_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/s3c2410_nand.c b/drivers/mtd/nand/s3c2410_nand.c > index db87d07..399f2bc 100644 > --- a/drivers/mtd/nand/s3c2410_nand.c > +++ b/drivers/mtd/nand/s3c2410_nand.c > @@ -43,7 +43,7 @@ static void s3c2410_hwcontrol(struct mtd_info *mtd, int > cmd, unsigned int ctrl) > struct nand_chip *chip = mtd->priv; > struct s3c2410_nand *nand = s3c2410_get_base_nand(); > > - debug("hwcontrol(): 0x%02x 0x%02x\n", cmd, ctrl); > + debug("hwcontrol(): 0x%02x 0x%08x\n", cmd & 0xff, ctrl);
What is the purpose of forcing extra zeroes in ctrl all the time? Why is the lack of such ugliness "just a bad idea"? Also, the masking of cmd is an unexplained change. -Scott _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
