On Wed, 2015-01-07 at 17:31 +0900, Joonyoung Shim wrote: > Hi, > > On 12/02/2014 10:56 AM, Hyungwon Hwang wrote: > > Dear Sjoerd, > > > > Thanks for this work. I think it is better to squash patch #1, #3, #4 > > into my patchs, because these patches remove the code which needlessly > > being added by my patches. I will include patch #2 also from next > > version. > > > > On Mon, 01 Dec 2014 13:34:16 +0100 > > Sjoerd Simons <[email protected]> wrote: > > > >> Hey Hyungwon, > >> > >> The following are some of the patches i had locally on top of your v9 > >> Odroid. Feel free to merge them into your patchset (or squash them > >> into your existing patches) if they look good to you. > >> > >> Sjoerd Simons (4): > >> Odroid-XU3: Drop redundant fields > >> Odroid-XU3: Add entry for DTS EHCI GPIO > >> ODROID-XU3: Make odroid-xu3 an smdk5420 variant > > I need to support odroid xu3 specific gpio setting e.g. to reset emmc > for reset command support. Also there are specific gpio setting codes > for only smdk5420 board on board/samsung/smdk5420/smdk5420.c and they > are not related with odroid xu3 board. > > So i think that need to split them.
For the gpio specific to the smdk5420 are you referring to the usb vbus gpio ? (For which i've dropped the code in a later, merged commit as it's handled by common code). > First, split board file. It's easiest way to make separate board > directory. > > Second, we can make just board file for odroid xu3 in same directory and > we should distinguish them from Makefile but i don't know this is > general way. > > Third, using same board file like now but we will need any way to > distinguish boards on runtime. To distinguish boards at runtime you should use the information from the DT file of the board rather then hardcoding it in a board file. -- Sjoerd Simons <[email protected]> Collabora Ltd.
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
