On 01/14/2015 04:14 PM, Simon Glass wrote: > On 14 January 2015 at 01:04, Michal Simek <[email protected]> wrote: >> Ensure that operations are correctly setup. >> >> Signed-off-by: Michal Simek <[email protected]> > > Reviewed-by: Simon Glass <[email protected]> > > (comment below) > >> --- >> >> drivers/fpga/xilinx.c | 17 +++++++++++++++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/fpga/xilinx.c b/drivers/fpga/xilinx.c >> index adb4b8cd25fd..9c95148b25c1 100644 >> --- a/drivers/fpga/xilinx.c >> +++ b/drivers/fpga/xilinx.c >> @@ -139,6 +139,11 @@ int xilinx_load(xilinx_desc *desc, const void *buf, >> size_t bsize, >> return FPGA_FAIL; >> } >> >> + if (!desc->operations || !desc->operations->load) { >> + printf("%s: Missing load operation\n", __func__); >> + return FPGA_FAIL; > > I wonder if these error codes should be dropped in favour of the > standard ones? Perhaps in a separate patch. E.g. here we could use > -ENOSYS.
Definitely. They are bogus. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
