Hi Simon, On Wed, Jan 28, 2015 at 1:17 PM, Simon Glass <s...@chromium.org> wrote: > Hi Bin, > > On 27 January 2015 at 07:00, Bin Meng <bmeng...@gmail.com> wrote: >> Hi Simon, >> >> On Tue, Jan 27, 2015 at 9:23 AM, Simon Glass <s...@chromium.org> wrote: >>> The base address is found in a different way and the protection bit is also >>> in a different place. Otherwise it is very similar. >>> >>> Signed-off-by: Simon Glass <s...@chromium.org> >>> --- >>> >>> drivers/spi/ich.c | 56 >>> ++++++++++++++++++++++++++++++++++++++++--------------- >>> drivers/spi/ich.h | 11 ++++++----- >>> 2 files changed, 47 insertions(+), 20 deletions(-) > > Just a note on this one...for v2 I have done nothing. I think we > should move it to device tree as you say but it needs some more > thought, as we have register offsets and device types to think about. > I will try a few things and test on link also. Once I have this I will > send a v3. So this patch will have to sit here until that is done, > hopefully only a few days. >
OK, I think we can just apply this patch for now along with other patches in this series. We can revisit this driver when adding DT and DM support. > Thanks for the quick reviews! > You are welcome! Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
