Hi,

On 04-02-15 09:27, Ian Campbell wrote:
On Wed, 2015-02-04 at 00:43 +0100, Hans de Goede wrote:
The recent changes to config_distro_bootcmd.h require CONFIG_CMD_PART to be
defined, as the default bootcmd not uses the "part" command.
                                    ^w

Shouldn't config_distro_bootcmd.h (or perhaps config_distro_defaults.h)
enable CMD_PART then? (adding some relevant CCs)

I was thinking the same myself, but I was not sure, so I thought lets go
with a quick fix for now and discuss this further on the list :)

A quick grep shows that config_distro_bootcmd.h is only included from
headers under include/configs/*.h, so enabling it there should get it
defined early enough for it to be properly picked up, so from my
pov yes that is a better solution.

Regards,

Hans


p.s.

Have you seen my reply to your review of "[PATCH 1/2] sunxi: video: Do not use 
CONFIG_SYS_MEM_TOP_HIDE for the framebuffer" ?
I'm waiting on input from you there on the fdt_fixup_memory_banks()
thingie, which I would prefer to keep as is. An "Acked-by" under
the condition that I fix up the Linux specific comments would be
welcome :)



Ian.

This fixes sunxi boards not booting with v2015.04-rc1.

Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
  include/configs/sunxi-common.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index bf60dcb..9e145f0 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -144,6 +144,9 @@
  #define CONFIG_CMD_MEMORY
  #define CONFIG_CMD_SETEXPR

+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_CMD_PART
+
  #define CONFIG_SETUP_MEMORY_TAGS
  #define CONFIG_CMDLINE_TAG
  #define CONFIG_INITRD_TAG


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to