Simon,
2015-02-19 23:08 GMT+09:00 Simon Glass <[email protected]>: > This should be a bool, not hex. > > Signed-off-by: Simon Glass <[email protected]> > Reported-by: Alexey Brodkin <[email protected]> > --- > > Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index 75bab7f..aa35ac9 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -58,7 +58,7 @@ config CC_OPTIMIZE_FOR_SIZE > > config SYS_MALLOC_F > bool "Enable malloc() pool before relocation" > - default 0x400 > + default y > help > Before relocation memory is very limited on many platforms. Still, > we can provide a small malloc() pool if needed. Driver model in > -- > 2.2.0.rc0.207.ga3a616c > It is OK to enable this option by default. For now, it is meaningless for non-DriverModel boards, but Driver Model will be the default in a long run. BTW, this series still could generate a broken .config file. I applied this series onto u-boot/master. masahiro@oscar:~/workspace/u-boot$ git log -3 --oneline f02712d kconfig: Adjust ordering so that defaults work as expected 755ad86 dm: Correct default value for SYS_MALLOC_F 1320112 Merge branch 'master' of git://git.denx.de/u-boot-fdt masahiro@oscar:~/workspace/u-boot$ make beaver_defconfig # # configuration written to .config # # # configuration written to spl/.config # masahiro@oscar:~/workspace/u-boot$ make menuconfig Go to "General setup" and disable "Enable malloc() pool before relocation" and save. masahiro@oscar:~/workspace/u-boot$ less .config [ snip ] CONFIG_DM_SPI_FLASH=y # CONFIG_SYS_MALLOC_F is not set CONFIG_SYS_MALLOC_F_LEN=0x1800 # CONFIG_DM_CROS_EC is not set # CONFIG_TEGRA20 is not set This is why I mentioned that "default 0x1800" must be followed by "if SYS_MALLOC_F". -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
