On Thu, Feb 19, 2015 at 10:41:04PM +0100, Angelo Dureghello wrote: > > > On 06/02/2015 17:02, Tom Rini wrote: > >On Mon, Jan 26, 2015 at 09:39:13AM +0000, Huan Wang wrote: > >>Hi, Tom, > >> > >>>On Thu, Jan 15, 2015 at 04:08:40PM +0100, Angelo Dureghello wrote: > >>>>Dear all, > >>>> > >>>>i would like to post a patch with the m68k generic board support, > >>>>tested and working here, but of course not tested for all the other > >>>>m68k boards except mine. > >>>> > >>>>My coldfire board is the "amcore" board not yet accepted. > >>>> > >>>>http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661 > >>>>http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660 > >>>> > >>>>I need some suggestions on how to proceed now. > >>>> > >>>>I already modified my board config to work with generic board support. > >>>> > >>>>So my thought is to post 2 separate patches: > >>>>1 > >>>>- add generic board (1/1). Each board maintainer should then test it > >>>>and report for feedbacks. > >>>>2 > >>>>Re-post a 2/2 patch (v8) of amcore using generic board: > >>>>- amcore board (1), > >>>>- mcf5307 support (2), > >>>> > >>>>This amcore board is the coldfire base i use here for all the general > >>>>m68k tests. > >>>> > >>>>With your help commenting on this patch until it is conformant to the > >>>>last recent coding guidelines could help me and Alison to know what > >>>>has to be purged / changed, (eventually, if needed) in all other m68k > >>>>boards code. > >>>> > >>>>What do you think ? > >>> > >>>Lets go with #2 and we'll purge the rest of the boards that you don't > >>>want to convert and compile test after -rc1. Thanks! > >>> > >>[Alison Wang] Do you mean you will purge the rest of the boards if > >>they are not converted and tested? > >> > >>I have these boards, such as m52277evb, m5253demo, m53017evb, > >>m5329evb, m5373evb, m54418twr, m54451evb, m54455evb, m547xevb and > >>m548xevb. I think I really need some time to convert and test them. > > > >Please get them converted ASAP and remove the rest of the boards which > >you do not plan to support. Thanks! > > Dear Tom and all, > > so basically, i posted a patch with with 1 and 2 together, since > "amcore" board and m68k generic-board additions was connected. > > Alison then added some changes over my generic-board patch. > > What is now the correct way to proceed, as m68k custodians ? We need to > wait for feedbacks/ack on the patches or, at what stage could we apply > this patches into the u-boot-coldfire repo ?
Go ahead and push them to u-boot-coldfire and send me a PR as they've been in public for long enough without further comments, thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot