On 02/27/2015 06:13 PM, Tom Rini wrote: > On Tue, Feb 24, 2015 at 09:02:09AM +0100, Michal Simek wrote: > >> Add basic Xilinx ZynqMP arm64 support. >> Serial and SD is supported. >> It supports emulation platfrom ep108 and QEMU. >> >> Signed-off-by: Michal Simek <[email protected]> > [snip] >> +/* Miscellaneous configurable options */ >> +#define CONFIG_SYS_LOAD_ADDR 0x8000000 >> + >> +/* Initial environment variables */ >> +#define CONFIG_EXTRA_ENV_SETTINGS \ >> + "ethaddr=00:0a:35:00:01:22\0" \ > > No, you can't hard-code an ethaddr in.
ah yeah. > >> + "kernel_addr=0x200000\0" \ >> + "initrd_addr=0xa00000\0" \ >> + "initrd_size=0x2000000\0" \ > > These are really close together. And I imagine mirror the usual values > on 32bit platforms. Maybe it's time to move them around a bit for more > space? Currently I haven't had any problem with these values but I just don't know what will happen in future. > >> + "fdt_addr=0x100000\0" \ >> + "fdt_high=0x10000000\0" \ > > We also shouldn't have to play "stop relocating the DT" games on > aarch64, right? Since all memory is visible and that's why we have to > do those games on aarch32. Will play with it to confirm it. >> + "sdboot=mmcinfo && fatload mmc 0:0 f000000 system.dtb && " \ >> + "fatload mmc 0:0 f000000 Image && booti 80000 - f000000\0" > > You aren't using $fdt_addr/$kernel_addr here and probably should? yes. I have this patch in my repo - will update and send v2. Thanks, Michal
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
