On 3/23/2015 12:38 AM, Andrew Gabbasov wrote: > Hi Troy, > >> From: Troy Kisky [mailto:troy.ki...@boundarydevices.com] >> Sent: Friday, March 20, 2015 9:39 PM >> To: peng....@freescale.com; Gabbasov, Andrew; u-boot@lists.denx.de >> Cc: Eric Nelson >> Subject: Re: [U-Boot] [PATCH 4/6] mmc: Continue polling MMC card for OCR >> only if it is still not ready >> >> [skipped] >> >> Here's another patch that solves the problem a little earlier. It has this >> disadvantage of being slightly bigger, though it makes the code look > better. >> >> https://github.com/boundarydevices/u-boot-imx6/commit/c0260ca >> > > I have a couple of doubts regarding that patch. > > First, my personal taste objects to such duplicating of the code > (I mean setting of version, ocr, rca, etc fields of mmc structure). > If we'll have to change or add anything to these settings, we'll have to > make > the same change in 2 different place, which is error-prone and extremely > inconvenient from maintenance point of view. > > Second, what about SPI mode? Doesn't this patch skip retrieving of OCR > register > with a special command for SPI host case (thus setting ocr field > incorrectly), > if the card comes to ready state with the first attempt?
That's a good argument for a subroutine to be doing that work instead of in two places. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot