On 03/25/2015 07:17 PM, Marcel Ziswiler wrote:
Bring the Colibri T20 configuration in-line with Apalis/Colibri T30.

I assume all the white-space and line reordering changes are so that a diff of colibri_t20.h and colibri_t30.h shows minimal differences?

diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h

+/* General networking support */
  #define CONFIG_CMD_NET
  #define CONFIG_CMD_DHCP
-#define CONFIG_CMD_NFS
-#define CONFIG_CMD_PING

It might warrant some explanation why those appear to be removed. Are they enabled by default anyway?

+/* Miscellaneous commands */
+#define CONFIG_CMD_SETEXPR
+#define CONFIG_FAT_WRITE
+
+/* Increase console I/O buffer size */
+#undef CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_CBSIZE              1024
+
+/* Increase arguments buffer size */
+#undef CONFIG_SYS_BARGSIZE
+#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
+
+/* Increase print buffer size */
+#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* Increase maximum number of arguments */
+#undef CONFIG_SYS_MAXARGS
+#define CONFIG_SYS_MAXARGS             32

Is any of that generally useful to other boards; do we want to add those lines to tegra*-common*.h instead?

(IIRC some of the command-line size related variables enable the ridiculously long kernel command-lines required to boot our downstream kernel, so would be useful on at least some other boards. Hence, enabling everywhere might be simplest).
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to