Hi, Le jeudi 18 décembre 2014 à 12:16 +0100, Marek Vasut a écrit : > On Thursday, December 18, 2014 at 09:32:56 AM, Ramneek Mehresh wrote: > > Hi Marex, > > > > Following u-boot patch is pending for your review for some time. Please let > > me know if you have any concerns. fsl/usb: Add USB XHCI support: > > http://patchwork.ozlabs.org/patch/373593/ > > I missed the patch completely, sorry. Next time, please keep me on CC when > submitting the patches, that helps a lot. > > As for the board_usb_init, you can drop the inline and the __board_usb_init() > and do: > > __weak int board_usb_init(int index, enum usb_init_type init) > { > return 0; > } > > The static void fsl_xhci_core_exit(struct fsl_xhci *fsl_xhci) must shut down > the controller, which I don't see happening. Why?
By the way, this is already defined in common/usb.c, so it's probably not worth duplicating it. On the other hand, it means that *HCI support would be broken (it applies to all other drivers usb board_usb_init) when not using CMD_USB, which I'm not sure is a good thing. -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: http://www.replicant.us/ Blog: http://blog.replicant.us/ Wiki/tracker/forums: http://redmine.replicant.us/
signature.asc
Description: This is a digitally signed message part
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
