Hi,

On 05/02/2015 04:03 PM, Ian Campbell wrote:
On Thu, 2015-04-30 at 16:35 +0200, Hans de Goede wrote:
+       if (hccr == (void *)SUNXI_USB1_BASE) {
+               priv->ahb_gate_mask = 1 << AHB_GATE_OFFSET_USB_EHCI0;
+               priv->phy_index = 1;

Inferring these from the base address is a bit unfortunate, should we
not get told this by the DT, or from something higher up?

I have a feeling the answer will be "this can go away when X, Y & X have
happened", in which case perhaps a comment to that affect?

Yes getting rid of this this requires us to move to the driver-model for
the phys reps. clocks. I'll add a comment to this extend.

Regards,

Hans
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to