Hi, On 30 July 2015 at 04:55, Masahiro Yamada <[email protected]> wrote: > > 2015-07-30 19:51 GMT+09:00 Bin Meng <[email protected]>: > > On Thu, Jul 30, 2015 at 6:47 PM, Masahiro Yamada > > <[email protected]> wrote: > >> 2015-07-30 19:42 GMT+09:00 Bin Meng <[email protected]>: > >>> Hi Haikun, Simon, > >>> > >>> On Fri, Jul 10, 2015 at 11:50 AM, Wang Haikun <[email protected]> > >>> wrote: > >>>> On 7/10/2015 6:06 AM, Simon Glass wrote: > >>>>> Hi, > >>>>> > >>>>> On 9 July 2015 at 05:58, Haikun Wang <[email protected]> wrote: > >>>>>> Showing both: > >>>>>> Model: Freescale Layerscape 2085a QDS Board > >>>>>> Board: LS2085E-QDS, Board Arch: V1, Board version: B, boot from vBank: > >>>>>> 4 > >>>>> > >>>>> This looks like duplication (at least the first part). > >>>>> > >>>>> Anyway I don't see any problem with this change. > >>>> Hi Simon, > >>>> > >>>> The "model" information is hard-coded. > >>>> Sometimes we need print run-time information of the board. > >>>> > >>>> We just want to print the version information and they are stored in the > >>>> on-board FPGA registers on LS2085AQDS. > >>>> > >>>> Best regards, > >>>> Wang Haikun > >>>>> > >>>>> Reviewed-by: Simon Glass <[email protected]> > >>> > >>> With rebase on u-boot/master, I now see board booting like this: > >>> > >>> Model: Intel Bayley Bay > >>> Board: Unknown > >>> > >>> This looks a little bit odd (an unkown board?) to me. Does this mean > >>> we need implement our own checkboard() for every board we support? > >>> > >> > >> > >> Absolutely, no. > >> > >> I do not want to implement checkboard() for my boards that > >> have model names in DTS. > >> > > > > Then can we make this __weak checkboard() print nothing instead? > > Sounds good to me. > > > > > > > Showing "Board: Unknown" makes me think something went wrong at first > > glance. >
I missed this impact of the patch. Yes that sounds good - Bin are you going to do a new patch? Regards, Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
